Add Grid sample#46
Open
JonEckenrode wants to merge 7 commits intomainfrom
Open
Conversation
JonEckenrode
requested review from
chikoski,
cka-dev and
juliantoledo
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new Android project named Grid that demonstrates a three-column layout using the experimental Compose Grid API, including the complete project structure and build configuration. Feedback focuses on correcting several futuristic or unsupported versions for the Android SDK, Gradle Plugin, Kotlin, and Compose BOM to ensure build stability. Additionally, suggestions were made to improve code consistency by utilizing the version catalog for all dependencies, adopting idiomatic Compose functions like luminance(), and refining modifier logic.
JonEckenrode
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a Grid sample for the adaptive apps development hub samples page.