Skip to content

Build environment updates for AGDK samples#119

Merged
natetrost merged 2 commits into
android:mainfrom
natetrost:main
Jun 23, 2026
Merged

Build environment updates for AGDK samples#119
natetrost merged 2 commits into
android:mainfrom
natetrost:main

Conversation

@natetrost

Copy link
Copy Markdown
Contributor

Updates the gradle/AGP/AGDK/dependency
versions of the ADPF, game controller and
game mode samples to bring them up to date
(matching AGDKTunnel).

Updated README to reflect target Android Studio
version.

Minor compile fix for compatibility with
current implot.

Updates the gradle/AGP/AGDK/dependency
versions of the ADPF, game controller and
game mode samples to bring them up to date
(matching AGDKTunnel).

Updated README to reflect target Android Studio
version.

Minor compile fix for compatibility with
current implot.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several AGDK samples (adpf, game_controller, and game_mode) to modern build configurations, including upgrades to Android SDK 37, NDK 29, Gradle 9.4.1, AGP 9.2.1, and various AndroidX dependencies, alongside updating ImPlot drawing calls in demo_scene.cpp. Feedback highlights a potential crash in demo_scene.cpp when plotting empty graph buffers, and recommends removing the obsolete android.uniquePackageNames property from gradle.properties across all samples to prevent build configuration issues with the upgraded AGP version.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread agdk/adpf/app/src/main/cpp/demo_scene.cpp Outdated
Comment thread agdk/adpf/gradle.properties Outdated
Comment thread agdk/game_controller/gradle.properties Outdated
Comment thread agdk/game_mode/gradle.properties Outdated
@natetrost natetrost merged commit 02f8717 into android:main Jun 23, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant