fix(cdk/scrolling): scrollToIndex combined with cdkVirtualScrollingEe…#33117
Open
Harpush wants to merge 1 commit into
Open
fix(cdk/scrolling): scrollToIndex combined with cdkVirtualScrollingEe…#33117Harpush wants to merge 1 commit into
Harpush wants to merge 1 commit into
Conversation
…ment can result in wrong scroll offset Fixes a bug when using cdkVirtualScrollingElement and there is some space between the scrolling element and the viewport the scroll to index function doesn't take into account the viewport offset from the scrolling container. Fixes angular#33063
Harpush
force-pushed
the
cdk-virtual-scroll-offset-scroll-relative-to
branch
from
0303207 to
55f8e6d
Compare
Author
|
@crisbeto @adolgachev any chance to review this? |
Author
|
@crisbeto @adolgachev now with v22 released - any chance for this to be reviewed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ment can result in wrong scroll offset
Fixes a bug when using cdkVirtualScrollingElement and there is some space between the scrolling element and the viewport the scroll to index function doesn't take into account the viewport offset from the scrolling container.
Fixes #33063