Skip to content

fix(material/select): stop event propagation on keyboard close in inl… #33210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yannyannyann wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(material/select): stop event propagation on keyboard close in inl… #33210

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/material/select/select.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -942,6 +942,11 @@ export class MatSelect
if (isArrowKey && event.altKey) {
// Close the select on ALT + arrow key to match the native <select>
event.preventDefault();
// Stop propagation so the event doesn't bubble to the host element and trigger
// _handleClosedKeydown, which would re-open the panel immediately.
event.stopPropagation();
// Restore focus to the trigger before closing so focus isn't lost when the overlay detaches.
this.focus();
this.close();
// Don't do anything in this case if the user is typing,
// because the typing sequence can include the space key.
Expand All @@ -952,6 +957,9 @@ export class MatSelect
!hasModifierKey(event)
) {
event.preventDefault();
// Stop propagation so the event doesn't bubble to the host element and trigger
// _handleClosedKeydown, which would re-open the panel immediately.
event.stopPropagation();
manager.activeItem._selectViaInteraction();
} else if (!isTyping && this._multiple && keyCode === A && event.ctrlKey) {
event.preventDefault();
Expand Down
Loading