QuantityValue implemented as a fractional number 🐲 by lipchev · Pull Request #1544 · angularsen/UnitsNet

lipchev · 2025-04-13T12:52:06Z

QuantityValue implemented as a fractional number
IQuantity interfaces optimized (some methods refactored as extensions)
UnitInfo: introduced two new properties: ConversionFromBase and ConversionToBase which are used instead of the switch(Unit) conversion
UnitsNetSetup: introduced helper methods for adding external quantities, or re-configuring one or more of the existing ones
UntAbbreviationsCache: introduced additional factory methods (using a configuration delegate)
UnitParser: introduced additional factory methods (using a configuration delegate)
UnitConverter: re-implemented (multiple versions)
Inverse relationship mapping implemented as a type of implicit conversion
updated the JsonNet converters
introducing the SystemTextJson project
added a new UnitsNetConfiguration project to the Samples, showcasing the new configuration options
many more tests and benchmarks (perhaps too many)

- IQuantity interfaces optimized (some methods refactored as extensions) - QuantityInfo/UnitInfo hierachy re-implemented (same properties, different constructors) - QuantityInfoLookup is now public - UntAbbreviationsCache, UnitParser, QuantityParser optimized - UnitConverter: re-implemented (multiple versions) - removed the IConvertible interface - updated the JsonNet converters - introducing the SystemTextJson project - added a new UnitsNetConfiguration to the Samples project showcasing the new configuration options - many more tests and benchmarks (perhaps too many)

lipchev · 2025-04-13T12:58:45Z

@angularsen Clearly, I don't expect this to get merged in the Gitty up! fashion, but at least we have the whole picture, with sources that I can reference.

If you want, send me an e-mail, we could do a quick walk-through / discussion.

…lection constructors with IEnumerable - `UnitAbbreviationsCacheInitializationBenchmarks`: replaced some obsolete usages

angularsen · 2025-04-18T18:36:28Z

100k lines removed, 100k lines added 🙈

lipchev · 2025-04-18T19:52:03Z

100k lines removed, 100k lines added 🙈

I tried to create this PR twice before (many months ago), while the changes to the unit definitions were still not merged- and the web interface was giving me an error when trying to browse the files changed.. Something like "Too many files to display" 😄

angularsen · 2025-04-18T20:18:10Z

Ok, I'm not going to get through a review of this many files anytime soon.
Maybe we should have a screen sharing session and go through it together. I may have some time this weekend, what about you? What timezone are you in?

On the surface though, it seems like this could be split up into chunks. I know it's tedious and extra work, but it will be way faster to review. Do you see any chunks of changes to easily split off into separate PRs?

lipchev · 2025-04-18T20:43:25Z

angularsen · 2025-04-18T21:41:22Z

Ok, sounds good. Just send PRs my way and I'll try to get to them. I have a little bit of extra time this weekend.

…ges)

…ions into their own folder

- UnitAbbreviationsCache: removing the obsolete overload - adding a few more tests

github-actions · 2025-06-21T02:32:10Z

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions · 2025-06-28T02:32:19Z

This PR was automatically closed due to inactivity.

…ramework (net8.0) with 9.0 on the QuantityInfoBenchmarks

github-actions · 2026-05-30T03:04:26Z

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions · 2026-06-06T03:04:39Z

This PR was automatically closed due to inactivity.

lipchev · 2026-06-22T05:03:14Z

@angularsen I've reopened this:

I've sync the changes from upstream (see 7d1f055) - I kept the obsolete usages, as to avoid the performance overhead of the dictionary lookup. I'm not too sure about the extension methods, and the usages of the default configuration - we can make the IQuantity.QuantityInfo property internal, or we could force the converter to do the dictionary lookup. However we should note that if we were to completely remove the IQuantity.QuantityInfo property from the #NET build, then using the GetQuantityInfo extension would fail for HowMuch, unless it is registered in the default configuration.
I've made the QuantityValue -> double operator implicit. I tested the package with my own projects and frankly there were significantly more line changes that I had to make in order to get everything to compile, compared to the actual migration of IQuantity.Value to QuantityValue 😆 I don't think this would be the case for most people, but there were a lot of Assert.Equals that failed for me too...
Finally, I removed the EmitDefaultValue = false from the quantity unit and value

Extracted from #1544 because deterministic code generation is independent of the QuantityValue feature and improves the existing generator on its own. Moving it out reduces the size and conflict surface of the original PR. Changes: - Deserialize relation definitions without relying on SortedSet's current-culture comparer. - Normalize relations with an ordinal, case-insensitive immutable sorted set before parsing and rewriting the file. Tests: - No test cases changed; verified by running the full code generator and confirming it produced no unrelated generated-file changes.

Extracted from #1544 because format-string parsing is unrelated to QuantityValue and is a standalone correctness improvement for the existing formatter. Moving it out keeps the feature PR focused and lets this behavior ship independently. Changes: - Parse significant-digit, abbreviation-index, currency, and percent suffixes with invariant culture. - Apply the same parsing rules to the span-based and .NET Framework-compatible code paths. Tests: - Add Format_CustomSpecifierSuffix_ParsesUsingInvariantCulture for abbreviation and significant-digit formats.

Extracted from #1544 because representing a unit system for only the dimensions an application uses is useful independently of QuantityValue. Moving it out gives the API change focused review and reduces the original PR's scope. Changes: - Allow UnitSystem to be constructed from any BaseUnits value defining at least one dimension. - Continue rejecting null and fully undefined base-unit sets. - Clarify the constructor documentation and exception message. Tests: - Change the seven previously rejected one-dimension-missing cases to assert successful construction. - Add a single-dimension UnitSystem case. - Add a dedicated assertion that BaseUnits.Undefined remains invalid.

Extracted from #1544 because composing an isolated quantity catalog is useful for custom quantities without depending on QuantityValue. Moving this API out gives the catalog design focused review and reduces the feature PR's size and initialization surface. Changes: - Add QuantitiesSelector for appending external quantity definitions to a base catalog. - Add configured factory overloads for QuantityInfoLookup, UnitAbbreviationsCache, and UnitParser. - Allow parser factories to configure abbreviations before parser construction. - Add UnitsNetSetup.Create and a selection builder for isolated, consistently wired setups. - Keep UnitsNetSetup.Default behavior unchanged. Tests: - Add QuantitiesSelector coverage for base, chained additions, ordering, and null input. - Add cache factory coverage for default and custom base catalogs. - Add parser factory coverage for external quantities and custom abbreviations. - Add isolated setup coverage for component wiring, catalog selection, additions, and duplicate base selection.

Extracted from #1544 (#1544) because choosing the global quantity catalog is an independent setup capability, not a requirement of fractional QuantityValue. Keeping it separate makes the singleton initialization and compatibility implications explicit and allows this commit to be deferred without blocking the isolated factory APIs. Changes: - Lazily create UnitsNetSetup.Default from the existing setup builder. - Add ConfigureDefaults for selecting the global catalog before first use. - Synchronize configuration and creation so concurrent first access cannot observe a partially configured builder. - Reject configuration after the singleton has been created. Tests: - Add a dedicated test assembly so global singleton state is isolated from the existing suite. - Verify configured catalog selection, default cache/parser wiring, excluded units, and rejection of reconfiguration. - Run the regression on net10.0 and net48 (1 test per target).

Extracted from #1544 because choosing the global quantity catalog is an independent setup capability, not a requirement of fractional QuantityValue. Keeping it separate makes the singleton initialization and compatibility implications explicit and allows this commit to be deferred without blocking the isolated factory APIs. Changes: - Lazily create UnitsNetSetup.Default from the existing setup builder. - Add ConfigureDefaults for selecting the global catalog before first use. - Synchronize configuration and creation so concurrent first access cannot observe a partially configured builder. - Reject configuration after the singleton has been created. Tests: - Add a dedicated test assembly so global singleton state is isolated from the existing suite. - Verify configured catalog selection, default cache/parser wiring, excluded units, and rejection of reconfiguration.

codecov · 2026-07-23T22:17:38Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97%. Comparing base (9cd9c6d) to head (f7053dc).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##           master   #1544      +/-   ##
=========================================
  Coverage      96%     97%              
=========================================
  Files         457     237     -220     
  Lines       30163   18371   -11792     
=========================================
- Hits        29098   17880   -11218     
+ Misses       1065     491     -574

Flag	Coverage Δ
net48	`97% <ø> (+1%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

angularsen · 2026-07-23T23:11:14Z

@lipchev I took the liberty of splitting out some more changes and syncing this PR branch again.

lipchev added discuss difficulty-hard breaking-change labels Apr 13, 2025

adding the git-ignored files

e421a1b

lipchev mentioned this pull request Apr 14, 2025

ILinearQuantity, ILogarithmicQuantity and IAffineQuantity interfaces #1461

Closed

lipchev added 2 commits April 18, 2025 00:27

changing the CultureInfo? parameters back to IFormatProvder?

53f00cd

- UnitAbbreviationsCahe and UnitParser: replaced the IReadOnlyCol…

e339d87

…lection constructors with IEnumerable - `UnitAbbreviationsCacheInitializationBenchmarks`: replaced some obsolete usages

lipchev added 6 commits April 19, 2025 03:09

including the changes from angularsen@f9a2766

d3092bc

Completed the QuantityFormatter test coverage (and some cosmetic chan…

5693259

…ges)

UnitKey: making the constructor internal and renaming the properties

b027df2

removing the QuantityFormatter overloads and re-organizing the extens…

e23973a

…ions into their own folder

- updating the implicit usings and cleanup some of the using statements

fe0a4c9

- UnitAbbreviationsCache: removing the obsolete overload - adding a few more tests

adding a few more tests

56b1df9

This was referenced Apr 23, 2025

QuantityInfo: internalizing the UnitInfo construction #1555

Merged

✨Set IsAotCompatible for net7.0 or later #1543

Merged

lipchev mentioned this pull request May 30, 2025

Make Custom Unit Extension Work Like Built-In Units #1562

Closed

github-actions Bot added the no-pr-activity label Jun 21, 2025

github-actions Bot closed this Jun 28, 2025

lipchev added 3 commits July 25, 2025 22:15

removing some unnecessary using statements and replacing the target f…

da9a3e9

…ramework (net8.0) with 9.0 on the QuantityInfoBenchmarks

renaming the default quantity provider

345ae06

removing Quantity.FromQuantityInfo

3c84a32

lipchev mentioned this pull request Apr 13, 2026

UnitsNet should prefer algebraic closure over assuming usage context #1653

Closed

github-actions Bot added the no-pr-activity label May 30, 2026

github-actions Bot closed this Jun 6, 2026

lipchev added 2 commits June 22, 2026 03:36

merged from upstream and bumped the version to 6.0.0-pre102

7d1f055

bump the rest of the packages to 6.0.0-pre102

3bc5217

lipchev reopened this Jun 22, 2026

making the QuantityValue -> double operator implicit

875e462

github-actions Bot removed the no-pr-activity label Jun 22, 2026

lipchev added 2 commits June 22, 2026 06:26

removing the EmitDefaultValue = false from the quantity unit and value

11c825f

bumping the samples package reference

2d14c5c

angularsen mentioned this pull request Jul 23, 2026

Allow configuring global default quantities #1692

Merged

Merge remote-tracking branch 'origin/master' into pr-1544

f7053dc

angularsen mentioned this pull request Jul 23, 2026

Move IQuantity conversion members to extensions #1696

Draft

Conversation

lipchev commented Apr 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lipchev commented Apr 13, 2025

Uh oh!

angularsen commented Apr 18, 2025

Uh oh!

lipchev commented Apr 18, 2025

Uh oh!

angularsen commented Apr 18, 2025

Uh oh!

lipchev commented Apr 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

angularsen commented Apr 18, 2025

Uh oh!

github-actions Bot commented Jun 21, 2025

Uh oh!

github-actions Bot commented Jun 28, 2025

Uh oh!

github-actions Bot commented May 30, 2026

Uh oh!

github-actions Bot commented Jun 6, 2026

Uh oh!

lipchev commented Jun 22, 2026

Uh oh!

codecov Bot commented Jul 23, 2026

Codecov Report

Uh oh!

angularsen commented Jul 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

lipchev commented Apr 13, 2025 •

edited

Loading

lipchev commented Apr 18, 2025 •

edited

Loading