fix: derive TLS path from wiki dir for service compatibility#32
Merged
Conversation
When running as a Windows service (SYSTEM account) or via sudo, os.UserHomeDir() returns the wrong home directory. The server couldn't find the certs generated by the user. Fix: derive TLS dir as a sibling of the wiki dir (e.g. ~/.mind-map/wiki -> ~/.mind-map/tls). The wiki dir is always passed correctly via --dir.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, the service runs as SYSTEM, so
os.UserHomeDir()returnsC:\Windows\system32\config\systemprofileinstead ofC:\Users\<name>. The server couldn't find the certs generated by the user and fell back to plain HTTP on port 443, causingERR_SSL_PROTOCOL_ERROR.Fix: Derive the TLS directory as a sibling of the wiki directory (
~/.mind-map/wiki→~/.mind-map/tls). The wiki dir is always passed correctly via--dir, so it works regardless of which user the service runs as.Also fixes the same issue on Linux when running via
sudo.