improvement(startup): split into methods and add timing#20593
Open
david-allison wants to merge 22 commits intoankidroid:mainfrom
Open
improvement(startup): split into methods and add timing#20593david-allison wants to merge 22 commits intoankidroid:mainfrom
david-allison wants to merge 22 commits intoankidroid:mainfrom
Conversation
c1248b9 to
b3256d6
Compare
* extract to a method: 'initAnkiBackend' to simplify startup * change from uncommenting to a parameter * add 'AmkiDroidApp.setup' call: * log execution time * simplify try... catch
* extract to a method: 'setupContextMenus' * document a little
* time to execute
* time to execute
* extract + log time to execute
It didn't need to be so high up
b3256d6 to
a80c17c
Compare
Combine two similar checks
Issue 20168
Cleaner to have them inside the methods themselves We will update 'setup' later to handle 20168 Issue 20168 Assisted-by: Calude Opus 4.6 move 'setup' calls inside the methods, but use a block body, rather than '= setup' syntax
a80c17c to
33a901f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Assisted-by: Claude Opus 4.6 - one commit:
Purpose / Description
I wanted a common method which would handle startup:
Fixes
Approach
setup, which performs the logging & timing of methodsAnkiContextorCrashReportingContext, and require their use via context providersHow Has This Been Tested?
Checklist