Skip to content

fix(app): avoid shortcut settings flash#35349

Open
opencode-agent[bot] wants to merge 2 commits into
devfrom
settings-flash-fix
Open

fix(app): avoid shortcut settings flash#35349
opencode-agent[bot] wants to merge 2 commits into
devfrom
settings-flash-fix

Conversation

@opencode-agent

@opencode-agent opencode-agent Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Summary

  • use controlled tab state in both the legacy and V2 settings dialogs
  • wrap every settings tab navigation in Solid's startTransition so the current tab remains painted while the next tab renders

Validation

  • bun typecheck (packages/app)
  • Prettier check for settings-keybinds.tsx
  • Playwright at 1280×800 using the real app UI with mocked backend data
  • Playwright navigated General, Shortcuts, Servers, Providers, and Models with 188 animation-frame samples and no blank frames or errors
  • Synchronized before/after video

Comparison

  • before: b44bc0ad0740afe80beae0a1981c2c4d96f67173
  • after: 86e4358319e10097124ce704d4c70c409d23f167

@opencode-agent opencode-agent Bot assigned Brendonovich and unassigned jayair Jul 4, 2026
@opencode-agent opencode-agent Bot marked this pull request as ready for review July 4, 2026 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants