Revert to before pre-commit was updated#850
Open
Andy-Grigg wants to merge 2 commits into
Open
Conversation
Reverts the following commits: - 05f9d8f Bump ansys/actions/release-pypi-private from 10.3.3 to 10.3.4 - c0f5bd5 Bump mypy from 2.1.0 to 2.2.0 - ca6e532 Bump actions/labeler from 6.1.0 to 6.2.0 - 746dacf Revert changes made by precommit CI - 73ba107 Bump ansys/actions/release-pypi-private from 10.3.2 to 10.3.3 - 2118a1c [pre-commit.ci] pre-commit autoupdate Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are still seeing an issue where black is formatting generated code in a non-idempotent way. With a lack of other options, I'm creating this PR to get us back to a state before pre-commit was updated, which as far as I can tell is when this started.
Reverts the following commits:
Edit: This seems to have resolved the issue. Triggering client generation on this branch results in code which passes the subsequent style check. I'll create a ticket to investigate this later, and maybe to look at moving to a different formatting tool.