Autoload Patchwork.php in Composer configuration#44
Autoload Patchwork.php in Composer configuration#44RubieV wants to merge 1 commit intoantecedent:masterfrom
Conversation
Composer nor autoloading seems to not be included in the tests, adding tests around this change might be beneficial.
|
The manual loading policy is deliberate. Patchwork is first and foremost a testing tool, and tests often reside in the same codebase as the system-under-test. Add the fact that Patchwork slows things down considerably, and now we have a problem: we have to selectively enable Patchwork during testing only, or else we default to negatively impacting the production performance. But let me know if you have an decent solution for the latter :) |
|
I assume you will add a dev-dependency on Patchwork in Composer if you only want Patchwork during tests. Since changing this behavior will have unexpected results for integrations that do manual loading, I would propose a (minor) version increment. |
|
Can we close this PR as "not planned" ? This is not the right way to do things. |
|
@jrfnl, I agree. |
Composer nor autoloading seems to not be included in the tests, adding tests around this change might be beneficial.