feat: display syntax errors for settings and workflow config#1278
Open
atharva-deopujari wants to merge 1 commit into
Open
feat: display syntax errors for settings and workflow config#1278atharva-deopujari wants to merge 1 commit into
atharva-deopujari wants to merge 1 commit into
Conversation
Author
|
Closing - looks like this has already been addressed. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Syntax errors in
.claude/settings.jsonand workflow inputs likeallowed_toolsare currently silently ignored, making debugging difficult for users. This adds clear error messages when configuration has issues.Changes
base-action/src/setup-claude-code-settings.ts.claude/settings.jsonor thesettingsinput contains invalid JSONcore.warning()for recoverable issues (corrupt existing file) andcore.error()for blocking issues (bad input)base-action/src/parse-sdk-options.ts-prefixes) inallowed_tools/disallowed_toolsentries, a common mistake when using pipe (|) notation in workflow YAMLcore.warning()with a corrective example and strip the markers so tools still workTests
All 42 tests pass. Typecheck clean.
Fixes #242