fix: URL-encode branch names in GitHub API calls#1326
Open
anishesg wants to merge 1 commit into
Open
Conversation
Branch names containing special characters like # were failing when used in GitHub API calls because these characters have special meaning in URLs. The API would interpret # as a fragment separator, truncating the branch name and causing 404 errors. This fix introduces `encodeBranchNameForAPI` that wraps `encodeURIComponent` to properly percent-encode branch names before they are used in API paths. The function is applied in `branch.ts`, `branch-cleanup.ts`, `update-comment-link.ts`, and `github-file-ops-server.ts` wherever branch names are inserted into API URLs. Operations like getting branch refs, comparing commits, deleting branches, and updating refs now handle special characters correctly. Signed-off-by: anish <anishesg@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branch names containing special characters like # were failing when used in GitHub API calls because these characters have special meaning in URLs. The API would interpret # as a fragment separator, truncating the branch name and causing 404 errors. This fix introduces
encodeBranchNameForAPIthat wrapsencodeURIComponentto properly percent-encode branch names before they are used in API paths. The function is applied inbranch.ts,branch-cleanup.ts,update-comment-link.ts, andgithub-file-ops-server.tswherever branch names are inserted into API URLs. Operations like getting branch refs, comparing commits, deleting branches, and updating refs now handle special characters correctly.Fixes #1314