Cleanup: Enforce keyword-only session in db_cleanup

[Gautam-Bharadwaj]

Enforce keyword-only session parameters in db_cleanup utility functions and update tests to adhere to Airflow 3 standards.

---

Was generative AI tooling used to co-author this PR?

• Yes

---

• Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
• For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
• When adding dependency, check compliance with the ASF 3rd Party License Policy.
• For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

[potiuk]

@Gautam-Bharadwaj This PR has been converted to draft because it does not yet meet our Pull Request quality criteria.

Issues found:

• ❌ Pre-commit / static checks: Failing: CI image checks / Static checks. Run prek run --from-ref main locally to find and fix issues. See Pre-commit / static checks docs.
• ❌ mypy (type checking): Failing: CI image checks / MyPy checks (mypy-providers). Run prek --stage manual mypy-providers --all-files locally to reproduce. You need breeze ci-image build --python 3.10 for Docker-based mypy. See mypy (type checking) docs.
• ❌ Other failing CI checks: Failing: check-newsfragment-pr-number. Run prek run --from-ref main locally to reproduce. See static checks docs.

Note: Your branch is 10 commits behind main. Some check failures may be caused by changes in the base branch rather than by your PR. Please rebase your branch and push again to get up-to-date CI results.

What to do next:

• The comment informs you what you need to do.
• Fix each issue, then mark the PR as "Ready for review" in the GitHub UI - but only after making sure that all the issues are fixed.
• There is no rush — take your time and work at your own pace. We appreciate your contribution and are happy to wait for updates.
• Maintainers will then proceed with a normal review.

Converting a PR to draft is not a rejection — it is an invitation to bring the PR up to the project's standards so that maintainer review time is spent productively. There is no rush — take your time and work at your own pace. We appreciate your contribution and are happy to wait for updates. If you have questions, feel free to ask on the Airflow Slack.

[SameerMesiah97]

Technically, this is a breaking change but these 2 methods are internal APIs that are invoked in a handful of places. I have left a few comments. Please fix CI as well.

[SameerMesiah97]

I don't have a strong opinion against including these tests but aren't they just testing python's built-in behavior when * is added to the method signature?

[SameerMesiah97]

Why did you only make a subset of the parameters keyword-only for this method when you made all parameters for drop_archived_tables keyword-only?

[Copilot]

Pull request overview

This PR updates airflow.utils.db_cleanup utility functions to enforce keyword-only argument passing (notably for session) and adjusts unit tests and release notes accordingly.

Changes:

• Made export_archived_records require keyword-only arguments after output_path (including session).
• Made drop_archived_tables fully keyword-only (including table_names, needs_confirm, and session).
• Updated unit tests and added a newsfragment documenting the behavior change.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
airflow-core/src/airflow/utils/db_cleanup.py	Updates function signatures to enforce keyword-only arguments.
airflow-core/tests/unit/utils/test_db_cleanup.py	Updates callers to use keywords and adds tests asserting positional calls fail.
airflow-core/newsfragments/63781.improvement.rst	Adds a release note about enforcing keyword-only parameters in db_cleanup.

Comments suppressed due to low confidence (1)

airflow-core/src/airflow/utils/db_cleanup.py:629

• The new * placement makes all parameters after output_path keyword-only (not just session). If the intent (per PR title/description) is only to enforce keyword-only session, consider moving * to just before session so existing positional uses of table_names/drop_archives/needs_confirm keep working (and adjust the new “positional_fails” test accordingly).

def export_archived_records(
    export_format: str,
    output_path: str,
    *,
    table_names: list[str] | None = None,
    drop_archives: bool = False,
    needs_confirm: bool = True,
    session: Session = NEW_SESSION,
) -> None:

[Copilot]

drop_archived_tables is now fully keyword-only (*, table_names, needs_confirm, session), which is a larger breaking change than “keyword-only session”. If you only need session to be keyword-only (per Airflow core guideline), you can keep table_names/needs_confirm positional-or-keyword and introduce *, session instead.

Suggested change

	*,
	table_names: list[str] | None,
	needs_confirm: bool,
	table_names: list[str] | None,
	needs_confirm: bool,
	*,

[Copilot]

These tests assert on a specific CPython TypeError wording/argument count substring (e.g. "takes 2 positional arguments but 6"). The exact message format can vary across Python versions/implementations, making this brittle. Consider asserting only that a TypeError is raised, or use pytest.raises(..., match=...) with a looser regex that doesn’t depend on the exact count/message text.

Suggested change

	with pytest.raises(TypeError) as exc:
	export_archived_records("csv", "path", ["table"], True, True, None)
	assert "takes 2 positional arguments but 6" in str(exc.value)
	def test_drop_archived_tables_positional_fails(self):
	with pytest.raises(TypeError) as exc:
	drop_archived_tables(["table"], True)
	assert "takes 0 positional arguments but 2" in str(exc.value)
	with pytest.raises(TypeError, match="positional arguments"):
	export_archived_records("csv", "path", ["table"], True, True, None)
	def test_drop_archived_tables_positional_fails(self):
	with pytest.raises(TypeError, match="positional arguments"):
	drop_archived_tables(["table"], True)