Skip to content

UI: Add custom RouterLink component#66945

Merged
choo121600 merged 5 commits into
apache:mainfrom
parkhojeong:ui-add-custom-router-link-component
May 16, 2026
Merged

UI: Add custom RouterLink component#66945
choo121600 merged 5 commits into
apache:mainfrom
parkhojeong:ui-add-custom-router-link-component

Conversation

@parkhojeong
Copy link
Copy Markdown
Contributor

@parkhojeong parkhojeong commented May 14, 2026

Follow-up to #66750 (comment)

the repeated code is in multiple places: <Link asChild color="fg.info"> <RouterLink /> </Link>
This PR introduces the custom RouterLink component and applies it to a small initial set of usages.

  • Once the component API is agreed on, I can migrate the remaining repeated usages.

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

@boring-cyborg boring-cyborg Bot added the area:UI Related to UI/UX. For Frontend Developers. label May 14, 2026
@bbovenzi
Copy link
Copy Markdown
Contributor

Looks great! Let's apply it everywhere

Copy link
Copy Markdown
Member

@choo121600 choo121600 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool :)

@parkhojeong parkhojeong force-pushed the ui-add-custom-router-link-component branch from cbdcf41 to d2b549c Compare May 14, 2026 16:46
Comment thread airflow-core/src/airflow/ui/src/pages/DagsList/DagCard.tsx Outdated
@parkhojeong parkhojeong requested a review from bbovenzi May 15, 2026 09:49
@choo121600
Copy link
Copy Markdown
Member

@parkhojeong — Your unresolved review thread(s) from @bbovenzi appear to have been addressed (post-review commits and/or in-thread replies on every thread, with the latest commit pushed after the most recent thread). I've added the ready for maintainer review label so the PR re-enters the maintainer review queue.

@bbovenzi — could you take another look when you have a chance? If you agree the feedback was addressed, please mark the threads as resolved so the queue signal stays accurate. If a thread still needs work, please reply in-line — @parkhojeong will follow up.


Note: This comment was drafted by an AI-assisted triage tool and may contain mistakes. Once you have addressed the points above, an Apache Airflow maintainer — a real person — will take the next look at your PR. We use this two-stage triage process so that our maintainers' limited time is spent where it matters most: the conversation with you.


Drafted-by: Claude Code (Opus 4.7); reviewed by @choo121600 before posting

@choo121600 choo121600 added the ready for maintainer review Set after triaging when all criteria pass. label May 15, 2026
@choo121600
Copy link
Copy Markdown
Member

Looks like the CI failure is unrelated to this PR. I'll rerun it :)

@choo121600 choo121600 added the backport-to-v3-2-test Mark PR with this label to backport to v3-2-test branch label May 16, 2026
@choo121600 choo121600 merged commit 42a85ee into apache:main May 16, 2026
143 of 144 checks passed
@github-actions github-actions Bot added this to the Airflow 3.2.3 milestone May 16, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Hi maintainer, this PR was merged without a milestone set.
We've automatically set the milestone to Airflow 3.2.3 based on: backport label targeting v3-2-test
If this milestone is not correct, please update it to the appropriate milestone.

This comment was generated by Milestone Tag Assistant.

@github-actions
Copy link
Copy Markdown
Contributor

Backport failed to create: v3-2-test. View the failure log Run details

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status Branch Result
v3-2-test Commit Link

You can attempt to backport this manually by running:

cherry_picker 42a85ee v3-2-test

This should apply the commit to the v3-2-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

If you don't have cherry-picker installed, see the installation guide.

@choo121600 choo121600 removed the backport-to-v3-2-test Mark PR with this label to backport to v3-2-test branch label May 16, 2026
@choo121600
Copy link
Copy Markdown
Member

Automatic backporting failed due to conflicts in 4 files, including DeadlineRow.tsx.
Since this is a refactor (not a bug fix), I’m removing the backport label for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers. ready for maintainer review Set after triaging when all criteria pass.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants