UI: Add custom RouterLink component#66945
Conversation
|
Looks great! Let's apply it everywhere |
cbdcf41 to
d2b549c
Compare
|
@parkhojeong — Your unresolved review thread(s) from @bbovenzi appear to have been addressed (post-review commits and/or in-thread replies on every thread, with the latest commit pushed after the most recent thread). I've added the @bbovenzi — could you take another look when you have a chance? If you agree the feedback was addressed, please mark the threads as resolved so the queue signal stays accurate. If a thread still needs work, please reply in-line — @parkhojeong will follow up. Note: This comment was drafted by an AI-assisted triage tool and may contain mistakes. Once you have addressed the points above, an Apache Airflow maintainer — a real person — will take the next look at your PR. We use this two-stage triage process so that our maintainers' limited time is spent where it matters most: the conversation with you. Drafted-by: Claude Code (Opus 4.7); reviewed by @choo121600 before posting |
|
Looks like the CI failure is unrelated to this PR. I'll rerun it :) |
|
Hi maintainer, this PR was merged without a milestone set.
|
Backport failed to create: v3-2-test. View the failure log Run detailsNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
You can attempt to backport this manually by running: cherry_picker 42a85ee v3-2-testThis should apply the commit to the v3-2-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continueIf you don't have cherry-picker installed, see the installation guide. |
|
Automatic backporting failed due to conflicts in 4 files, including DeadlineRow.tsx. |
Follow-up to #66750 (comment)
the repeated code is in multiple places:
<Link asChild color="fg.info"> <RouterLink /> </Link>This PR introduces the custom RouterLink component and applies it to a small initial set of usages.
Was generative AI tooling used to co-author this PR?