PR triage: drop failing job names from violations bullets#67322
Open
potiuk wants to merge 1 commit into
Open
Conversation
The contributor-facing triage comments currently enumerate every failing job name underneath each category (e.g. five Kubernetes test variants plus "(+1 more)"). The same job names are already visible in GitHub's Checks tab; repeating them in the comment adds noise and pushes the message past the size where contributors actually read it. Pin the bullet to the bare-category form via the override file. Per-category remediation snippets the framework default may add (e.g. inline "Run prek run ..." steps) are dropped too; the linked doc has them. Short single-clause inline payloads (unresolved-thread count, the existing "Multiple flagged PRs" line in `close`) remain permitted — the rule applies to multi-item job-name lists, not to all auxiliary text. The rest of the triage comment — link to the quality criteria, per-category doc URLs, "what to do next" / no-rush line, AI- attribution footer, two-stage-process link — is untouched.
potiuk
added
the
backport-to-v3-2-test
Collaborator
|
Nice, PR changes look good. Thanks |
This was referenced May 24, 2026
omkar-foss
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The contributor-facing PR-triage comments currently enumerate every failing job name underneath each category — e.g. five Kubernetes test variants plus
(+1 more)— for every PR that hits a CI failure. The same job names are already visible in GitHub's Checks tab; repeating them in the comment adds noise and pushes the message past the size where most contributors actually read it.This PR pins the
<violations>bullet to the bare-category form via.apache-steward-overrides/pr-management-triage-comment-templates.md:Run prek run ...steps) are dropped too — the linked doc has them.Multiple flagged PRsline inclose) remain permitted; the rule targets multi-item job-name lists.Discussed on the dev list — "RE: Re: [DISCUSS] PR auto-triage recent stats (how do we do more reviews)".
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 4.7) following the guidelines