Additional setup for Java SDK release#69444
Open
uranusjr wants to merge 5 commits into
Open
Conversation
6811235 to
3ba5e14
Compare
phanikumv
reviewed
Jul 6, 2026
See changes to the README file to understand what changed and for what purposes. Mostly just plumbing...
3ba5e14 to
7d34f47
Compare
phanikumv
reviewed
Jul 7, 2026
phanikumv
approved these changes
Jul 7, 2026
jason810496
reviewed
Jul 7, 2026
jason810496
left a comment
Member
There was a problem hiding this comment.
Here're some valid concerns / nits by CC along with the context from #69527.
This avoids a footgun where the RM runs the command on the wrong ref (e.g. the branch instead of the tag). The value from gitRef is always used, so the same result is produced no matter which ref the work tree is currently using.
jason810496
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See changes to the README file to understand what changed and for what purposes. Mostly just plumbing...