Authorize Dag reparse against the file's Dags, not the query-string dag_id#69471
Open
pierrejeambrun wants to merge 1 commit into
Open
Authorize Dag reparse against the file's Dags, not the query-string dag_id#69471pierrejeambrun wants to merge 1 commit into
pierrejeambrun wants to merge 1 commit into
Conversation
pierrejeambrun
requested review from
bugraoz93,
choo121600,
ephraimbuddy,
henry3260,
jason810496,
rawwar and
shubhamraj-git
as code owners
pierrejeambrun
force-pushed
the
authorize-reparse-by-file-token
branch
2 times, most recently
from
fd2e5ca to
0a56a1a
Compare
pierrejeambrun
requested review from
amoghrajesh,
ashb,
gopidesupavan,
jscheffl and
potiuk
as code owners
…ag_id
The PUT /parseDagFile/{file_token} endpoint authorized the caller through a route dependency that, with no dag_id path parameter, resolves the target from the query string, which is decoupled from the Dag file the signed file_token actually resolves to.
Add a requires_access_dag_from_file_token dependency that decodes the token, resolves the Dags defined in that file, and authorizes the caller against exactly those Dags, so authorization always matches the Dag being reparsed regardless of any request parameter.
pierrejeambrun
force-pushed
the
authorize-reparse-by-file-token
branch
from
0a56a1a to
814ab8e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PUT /api/v2/parseDagFile/{file_token}authorized the caller only through a route dependency that, with nodag_idpath parameter, resolves the per-Dag target from the query string — which is decoupled from the Dag file the signedfile_tokenactually resolves to. The handler already computed the correct per-Dag authorization requests from the file's Dags but only used them for an emptiness check.This enforces those requests via
batch_is_authorized_dag, so authorization matches the Dag actually reparsed. The coarse route dependency is kept as defense-in-depth, mirroring the import-errors, and also to keep the auto generated permission doc reliable.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 4.8) following the guidelines