Simplify airflowctl query parameter handling#69475
Open
henry3260 wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
For now, I prefer using a helper function instead of a decorator because there are only two call sites. We can revisit a decorator-based approach later if more airflowctl operations need the same query parameter handling. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
airflowctlAPI operations need to build query parameters consistently when optional filters are added. The Dag run list operation already had several repeated checks for skipping unset values and serializing datetimes, and similar optional parameter handling exists in other operations. Centralizing that logic makes future filters easier to add without duplicating the same query parameter handling.suggested by @bugraoz93 in #68564 (comment)
What
airflow-ctl/src/airflowctl/api/operations.pyto build query parameters and serializedatetimevalues withisoformat().DagRunOperations.list()to use the shared helper for state, date, logical date, ordering, and limit query parameters.JobsOperations.list()to use the same helper while preserving the existing behavior for emptyjob_typeandhostnamevalues.airflow-ctl/tests/airflow_ctl/api/test_operations.pycovering skippedNonevalues and datetime serialization.Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.