Clarify Task Instance terminal state reporting#69482
Open
fat-catTW wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Task SDK client previously exposed this operation as
finish(), but that name made it sound like the generic path for any task that stops executing. In practice, this method only reports non-success terminal Task Instance states; success, retry, defer, reschedule, and awaiting-input transitions use dedicated methods and payloads.Change
Rename the Task SDK client method used for non-success terminal Task Instance state updates from
finish()toset_terminal_state().This better reflects that success, retry, defer, reschedule, and awaiting-input states each use dedicated API payloads and should not fall back to this generic non-success terminal-state update.
Updated the supervisor call sites, comments, unit tests, and Task SDK integration test usage.
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.