Skip to content

Remove redundant session.commit() calls in FastAPI route handlers #69495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vincbeck merged 1 commit into from
Jul 7, 2026
+0 −5
Merged

Remove redundant session.commit() calls in FastAPI route handlers #69495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion airflow-core/src/airflow/api_fastapi/core_api/routes/public/backfills.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,6 @@ def pause_backfill(backfill_id: NonNegativeInt, session: SessionDep) -> Backfill
raise HTTPException(status.HTTP_409_CONFLICT, "Backfill is already completed.")
if b.is_paused is False:
b.is_paused = True
session.commit()
return b


Expand Down
2 changes: 0 additions & 2 deletions airflow-core/src/airflow/api_fastapi/core_api/routes/public/hitl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,8 +243,6 @@ def update_hitl_detail(
task_instance=locked_ti,
session=session,
)

session.commit()
return HITLDetailResponse.model_validate(hitl_detail_model)


Expand Down
1 change: 0 additions & 1 deletion airflow-core/src/airflow/api_fastapi/execution_api/routes/hitl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,6 @@ def update_hitl_detail(
hitl_detail_model.chosen_options = payload.chosen_options
hitl_detail_model.params_input = payload.params_input
session.add(hitl_detail_model)
session.commit()
return HITLDetailResponse.from_hitl_detail_orm(hitl_detail_model)


Expand Down
1 change: 0 additions & 1 deletion airflow-core/src/airflow/api_fastapi/execution_api/routes/xcoms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,5 +481,4 @@ def delete_xcom(
XComModel.map_index == map_index,
)
session.execute(query)
session.commit()
return {"message": f"XCom with key: {key} successfully deleted."}