fix: Cleanup's _validate_job_dir/build_*_cleanup_command hardcoded the#70098
Open
singlaamitesh wants to merge 1 commit into
Open
fix: Cleanup's _validate_job_dir/build_*_cleanup_command hardcoded the#70098singlaamitesh wants to merge 1 commit into
singlaamitesh wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #69813
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.Cleanup's validate_job_dir/build*_cleanup_command hardcoded the default base dir, so any custom remote_base_dir (validated more loosely at init) always failed cleanup at job completion; they now accept the operator's actual configured base_dir, and a changelog entry documenting the fix was added to providers/ssh/docs/changelog.rst.
How this was tested:
airflow dags test