Skip to content

fix: Cleanup's _validate_job_dir/build_*_cleanup_command hardcoded the#70098

Open
singlaamitesh wants to merge 1 commit into
apache:mainfrom
singlaamitesh:fix/69813-airflow-69813
Open

fix: Cleanup's _validate_job_dir/build_*_cleanup_command hardcoded the#70098
singlaamitesh wants to merge 1 commit into
apache:mainfrom
singlaamitesh:fix/69813-airflow-69813

Conversation

@singlaamitesh

Copy link
Copy Markdown
Contributor

Fixes #69813


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

Cleanup's validate_job_dir/build*_cleanup_command hardcoded the default base dir, so any custom remote_base_dir (validated more loosely at init) always failed cleanup at job completion; they now accept the operator's actual configured base_dir, and a changelog entry documenting the fix was added to providers/ssh/docs/changelog.rst.

How this was tested: airflow dags test

Copilot AI review requested due to automatic review settings July 19, 2026 13:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SSHRemoteJobOperator: inconsistent "remote_base_dir" validation

2 participants