[v3-3-test] Authorize Dag reparse against the file's Dags, not the query-string dag_id#70115
Merged
Merged
Conversation
…ag_id (apache#69471) * Authorize Dag reparse against the file's Dags, not the query-string dag_id The PUT /parseDagFile/{file_token} endpoint authorized the caller through a route dependency that, with no dag_id path parameter, resolves the target from the query string, which is decoupled from the Dag file the signed file_token actually resolves to. Add a requires_access_dag_from_file_token dependency that decodes the token, resolves the Dags defined in that file, and authorizes the caller against exactly those Dags, so authorization always matches the Dag being reparsed regardless of any request parameter. * Update airflow-core/src/airflow/api_fastapi/core_api/security.py Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com> * Fix CI --------- Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com> (cherry picked from commit c5faeb1)
pierrejeambrun
requested review from
amoghrajesh,
ashb,
bugraoz93,
choo121600,
ephraimbuddy,
gopidesupavan,
henry3260,
jason810496,
jscheffl,
potiuk,
rawwar and
shubhamraj-git
as code owners
July 20, 2026 07:53
Member
Author
|
unrelated CI failure, merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #69471 to
v3-3-test.Cherry-picked from c5faeb1.
Clean cherry-pick, no conflicts.
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 4.8) following the guidelines