Run check-provider-yaml-valid when prek scripts or providers config change#70230
Merged
Conversation
dabla
requested review from
amoghrajesh,
ashb,
bugraoz93,
choo121600,
ephraimbuddy,
gopidesupavan,
jason810496,
jedcunningham,
jscheffl,
potiuk and
vatsrahul1001
as code owners
July 22, 2026 11:22
boring-cyborg
Bot
added
area:dev-tools
backport-to-v3-3-test
1 task
…hange When only `scripts/ci/prek/check_provider_yaml_files.py` or `providers/.pre-commit-config.yaml` changed, selective checks incorrectly skipped `check-provider-yaml-valid` because those paths matched neither `ALL_PROVIDERS_DISTRIBUTION_CONFIG_FILES` nor `ALL_PROVIDERS_PYTHON_FILES`. This meant a bug introduced in the check script itself (like the path resolution bug in apache#70007) would go undetected in CI. Fix by: - Including `providers/.pre-commit-config.yaml` in `ALL_PROVIDERS_DISTRIBUTION_CONFIG_FILES` - Adding `PREK_FILES` as a third condition that keeps `check-provider-yaml-valid` from being skipped Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
dabla
force-pushed
the
fix/selective-tests-provider-hooks
branch
from
July 22, 2026 11:27
287e67c to
81fbfcb
Compare
amoghrajesh
reviewed
Jul 22, 2026
amoghrajesh
reviewed
Jul 22, 2026
dabla
force-pushed
the
fix/selective-tests-provider-hooks
branch
from
July 22, 2026 12:29
376320a to
101c4b7
Compare
Lee-W
approved these changes
Jul 22, 2026
bugraoz93
approved these changes
Jul 22, 2026
Contributor
Backport failed to create: v3-3-test. View the failure log Run detailsNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
You can attempt to backport this manually by running: cherry_picker ff0ac28 v3-3-testThis should apply the commit to the v3-3-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continueIf you don't have cherry-picker installed, see the installation guide. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, selective checks skip
check-provider-yaml-validunless aprovider.yaml,pyproject.toml, or provider Python file changed. This means that when onlyscripts/ci/prek/check_provider_yaml_files.pyorproviders/.pre-commit-config.yamlis modified, the check is silently skipped — so a bug introduced in the check script itself goes undetected in CI.This was the root cause of the
FileNotFoundErrorforproviders/apache/provider.yamlreported after #70007 merged: the_resolve_provider_yaml_files()function mapped any provider Python file to<pkg>/provider.yamlwithout guarding against non-provider-package paths likeapache/, butcheck-provider-yaml-validnever ran in that PR's CI to catch it.Changes
providers/.pre-commit-config.yamltoALL_PROVIDERS_DISTRIBUTION_CONFIG_FILESso changes to the providersprek configuration are treated like
provider.yamlchanges.PREK_FILESas an additional condition: when any prek scriptchanges,
check-provider-yaml-validis no longer skipped.dev/breeze/doc/ci/04_selective_checks.mdto document the newrule.
Related
Was generative AI tooling used to co-author this PR?
Claude Sonnet 4.6 (GitHub Copilot CLI)
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.