Skip to content

fix: attachment upload broken after v2.0.0 upgrade (#1525) #1527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robinv8 merged 1 commit into from
May 19, 2026
+9 −2
Merged

fix: attachment upload broken after v2.0.0 upgrade (#1525) #1527

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ui/src/components/Editor/ToolBars/file.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,7 @@ const File = () => {
uploadImage({ file: e.target.files[0], type: 'post_attachment' })
.then((url) => {
const text = `[${fileName}](${url})`;
editor.replaceRange('', startPos, endPos);
editor.replaceSelection(text);
editor.replaceRange(text, startPos, endPos);
Comment thread
robinv8 marked this conversation as resolved.
})
.catch(() => {
editor.replaceRange('', startPos, endPos);
Expand Down
8 changes: 8 additions & 0 deletions ui/src/components/Editor/utils/codemirror/base.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,14 @@ export function createBaseMethods(editor: Editor) {
});
},

replaceRange: (value: string, from: Position, to: Position) => {
const fromOffset = editor.state.doc.line(from.line).from + from.ch;
const toOffset = editor.state.doc.line(to.line).from + to.ch;
editor.dispatch({
changes: { from: fromOffset, to: toOffset, insert: value },
});
},

getValue: () => {
return editor.state.doc.toString();
},
Expand Down
Loading