fix(prometheus): bump nginx-lua-prometheus-api7 to 1.0.0 - #13754
Open
AlinsRan wants to merge 1 commit into
Open
Conversation
The 0.20260716 pin predates the fix for the shared-dict step-down: on a full metric dict, remove_expired_keys() did not reclaim expired entries, so usage ratcheted down until the dict filled and stayed full. 1.0.0 calls dict:flush_expired() to actually reclaim them. The dependency also switched to semantic versioning starting at 1.0.0 (its upstream is dormant and it is now maintained independently as a fork). Fixes apache#13658
dosubot
Bot
added
size:XS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bumps
nginx-lua-prometheus-api7from0.20260716-1to1.0.0-1.Why
0.20260716predates the fix for the shared-dict step-down bug (#13658): on a full metric dict,remove_expired_keys()never calleddict:flush_expired(), so expired entries were not reclaimed — usage ratcheted down until the dict filled and stayed full.1.0.0reclaims them.The dependency also switched to semantic versioning starting at
1.0.0: its upstream (knyar/nginx-lua-prometheus) is dormant (last release 2024-05), so the fork is now maintained independently and no longer tracks upstream date-based snapshots.1.0.0sorts above all previous0.YYYYMMDDversions in luarocks (major1>0), so this is a normal forward bump.nginx-lua-prometheus-api7-1.0.0-1is published on luarocks.Fixes #13658