fix(array): validate MakeFromData type IDs#904
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
zeroshade
reviewed
Jul 9, 2026
zeroshade
left a comment
zeroshade
left a comment
Member
There was a problem hiding this comment.
Correct fix — the old & 0x3f mask silently wrapped type IDs ≥ 64 onto the wrong constructor. One small nit inline.
| return makeArrayFn[byte(data.DataType().ID()&0x3f)](data) | ||
| id := int(data.DataType().ID()) | ||
| if id < 0 || id >= len(makeArrayFn) || makeArrayFn[id] == nil { | ||
| invalidDataType(data) |
Member
There was a problem hiding this comment.
Nit: prefer return invalidDataType(data) here. As written it relies on invalidDataType panicking as a side effect; returning it is clearer and stays correct even if that helper is ever changed to return a sentinel/typed error instead of panicking (otherwise execution would fall through to makeArrayFn[id](data) with an invalid id).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fail fast on invalid Arrow type IDs in
array.MakeFromDatainstead of masking and dispatching into the wrong constructor slot.Why this fix
MakeFromDatacurrently masks the type ID (& 0x3f) before table lookup. New or invalid IDs can wrap to valid indices, causing wrong constructors or nil dispatch and a confusing panic.Changes
intand validate it explicitly.len(makeArrayFn)nilconstructorsinvalidDataType(...)panic path for unsupported IDs.Files
arrow/array/array.goarrow/array/array_test.goValidation
TestMakeFromDatacase for invalid type64and assertion of panic text.Bug details