fix(array): validate JSON start offsets#929
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
fallintoplace
force-pushed
the
fix/json-start-offset-seek-validation
branch
from
a1e1d29 to
9019ab8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Validate
WithStartOffsetbefore JSON decoding. Negative offsets are rejected, seek errors are returned, and a seeker must report the requested position. The same validation is shared byFromJSONandRecordFromJSON.Tests
go test ./arrow/array -count=1pre-commit run golangci-lint-full --all-filesRegression coverage includes seek errors, incorrect positions, negative offsets that must not call
Seek, and a successful offset with the expected decoded values.