fix(cdata): validate imported array sizes#931
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The C array importer now validates all header counts and pointer arrays before creating native slices.
It also checks native-int conversion, length/offset arithmetic, bitmap and physical buffer sizes, binary-view size metadata, dictionary presence, and expected child/buffer counts before traversal. Invalid metadata returns an error instead of reaching unsafe buffer construction.
Tests cover negative and oversized headers, missing pointer arrays, root preflight before ownership transfer, and fixed-width/offset multiplication overflow paths.
Validation:
The full arrow test suite is otherwise blocked by missing repository fixtures under parquet-testing/data and arrow-testing/data/csv. Linux/386 cgo compilation is unavailable on this macOS host.