GH-1188: Reduce test workflow waste#1189
Open
xborder wants to merge 2 commits into
Open
Conversation
xborder
requested review from
jbonofre,
kou,
laurentgo,
lidavidm and
wgtmac
as code owners
This comment has been minimized.
This comment has been minimized.
kou
reviewed
Jun 15, 2026
kou
reviewed
Jun 21, 2026
Comment on lines
+178
to
+189
| const relevant = files.some(({ filename }) => | ||
| filename === 'compose.yaml' || | ||
| filename === 'pom.xml' || | ||
| filename === '.github/workflows/test.yml' || | ||
| filename.startsWith('c/') || | ||
| filename.startsWith('flight/') || | ||
| filename.startsWith('format/') || | ||
| filename.startsWith('vector/') || | ||
| filename.startsWith('ci/scripts/') || | ||
| filename.startsWith('testing/data/') || | ||
| filename.endsWith('/pom.xml') | ||
| ); |
Member
There was a problem hiding this comment.
Let's separate this job to another workflow and use paths: https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#onpushpull_requestpull_request_targetpathspaths-ignore .
If you work on this as a separated PR, we'll be able to merge this PR sooner.
| with: | ||
| path: .docker | ||
| key: maven-${{ matrix.jdk }}-${{ matrix.maven }}-${{ hashFiles('compose.yaml', '**/pom.xml', '**/*.java') }} | ||
| key: maven-${{ matrix.jdk }}-${{ matrix.maven }}-${{ hashFiles('compose.yaml', '**/pom.xml') }} |
Member
There was a problem hiding this comment.
Why is this needed?
If we don't update a cache by .java change, I think that we can't reuse cache for changed .java.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR reduces wasted GitHub Actions time in the
Testworkflow by removing redundant rebuilds, improving caching, and skipping integration work when it is not relevant.What changed
cleanfromci/scripts/test.shso the test phase reuses the classes compiled earlier in the job instead of deleting and recompiling them.pull-requests: readso the integration job can inspect changed files.Closes #1188
Note: The changes on this PR were highlighted and addressed with AI assistance