GH-49533: [R] Implement dplyr's when_any() and when_all() helpers#49535
Merged
thisisnic merged 3 commits intoapache:mainfrom Mar 27, 2026
Merged
GH-49533: [R] Implement dplyr's when_any() and when_all() helpers#49535thisisnic merged 3 commits intoapache:mainfrom
thisisnic merged 3 commits intoapache:mainfrom
Conversation
github-actions
bot
added
Component: R
awaiting committer review
Member
Author
|
@jonkeane - mind giving this a look over if you have the time? |
jonkeane
approved these changes
Mar 26, 2026
Member
jonkeane
left a comment
jonkeane
left a comment
There was a problem hiding this comment.
Thanks for this. One small question, but this looks good
Comment on lines
+530
to
+536
| # na_rm=TRUE treats NA as FALSE | ||
| compare_dplyr_binding( | ||
| .input |> | ||
| mutate(result = when_any(lgl, false, na_rm = TRUE)) |> | ||
| collect(), | ||
| tbl | ||
| ) |
Member
There was a problem hiding this comment.
I assume that lgl here has NAs and that's what is being tested here, right?
github-actions
bot
added
awaiting merge
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 4bcab12. There was 1 benchmark result with an error:
There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Bindings to new dplyr helpers
What changes are included in this PR?
Bindings and tests
Are these changes tested?
Yes
Are there any user-facing changes?
Yes
AI usage
I have written this using Claude Opus 4.5 using Claude from the cli. I have manually reviewed the changes myself and am happy with them.