GH-48590: [C++] Migrate SFINAE enable_if patterns to C++20 concepts#49599
Open
abhishek593 wants to merge 7 commits intoapache:mainfrom
Open
GH-48590: [C++] Migrate SFINAE enable_if patterns to C++20 concepts#49599abhishek593 wants to merge 7 commits intoapache:mainfrom
abhishek593 wants to merge 7 commits intoapache:mainfrom
Conversation
… keep SFINAE compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
We can replace the SFINAE-based enable_if_* patterns with C++20 concepts. This gives us better compiler diagnostics, cleaner code, and faster compile times.
What changes are included in this PR?
Note: I have broken down the migration into several commits so that each commit can be independently reviewed.
Are these changes tested?
Yes. No new tests needed since this is a pure refactor; the concept constraints are semantically equivalent to the old enable_if guards.
Are there any user-facing changes?
No functional changes. Template error messages from the compiler will be more readable on type mismatches. The old enable_if_* aliases remain available, and can be cleaned up in a follow-up PR.