GH-50295: [C++][R] #include <ranges> in vector_select_k.cc breaks macOS CRAN and wasm builds by thisisnic · Pull Request #50297 · apache/arrow

thisisnic · 2026-06-30T08:11:09Z

Rationale for this change

R build failures due CRAN toolchain

What changes are included in this PR?

Use version of functions available on CRAN toolchain

Are these changes tested?

By existing CI jobs, and additional unit tests.

Are there any user-facing changes?

No

GitHub Issue: [C++][R] #include <ranges> in vector_select_k.cc breaks macOS CRAN and wasm builds #50295

github-actions · 2026-06-30T08:11:35Z

⚠️ GitHub issue #50295 has been automatically assigned in GitHub to PR creator.

github-actions · 2026-06-30T08:11:36Z

⚠️ GitHub issue #50295 has no components, please add labels for components.

Copilot

Pull request overview

This PR addresses R build failures on the macOS CRAN toolchain and in wasm/emscripten by removing the dependency on the C++20 <ranges> header in the C++ select_k kernel implementation.

Changes:

Removed #include <ranges> from vector_select_k.cc.
Replaced std::ranges::{make_heap,pop_heap,push_heap} with iterator-based std::{make_heap,pop_heap,push_heap} usage.
Replaced std::ranges::reverse_view(...) output filling with manual reverse-index loops.

pitrou · 2026-06-30T08:22:59Z

cc @taepper

pitrou · 2026-06-30T08:25:53Z

+    for (int64_t i = output.non_null_like_range.size() - 1; i >= 0; --i) {
+      output.non_null_like_range[i] =


The Copilot comment is right but the suggested solution is ugly. Could be something like:

Suggested change

for (int64_t i = output.non_null_like_range.size() - 1; i >= 0; --i) {

output.non_null_like_range[i] =

for (int64_t i = output.non_null_like_range.size(); i > 0; --i) {

output.non_null_like_range[i - 1] =

or:

Suggested change

for (int64_t i = output.non_null_like_range.size() - 1; i >= 0; --i) {

output.non_null_like_range[i] =

for (auto it = output.non_null_like_range.rbegin();

it != output.non_null_like_range.rend(); ++it) {

*it =

I've pushed tests for the all-nulls case in thisisnic#34 @thisisnic

Cheers @pitrou

pitrou · 2026-06-30T08:26:14Z

-  for (auto& reverse_out_iter : std::ranges::reverse_view(output_range)) {
-    reverse_out_iter = heap.front();  // heap-top has the next element
-    std::ranges::pop_heap(heap, cmp);
+  for (int64_t i = output_range.size() - 1; i >= 0; --i) {


Copilot didn't notice, but this has the same problem as below.

github-actions · 2026-06-30T09:28:57Z

⚠️ GitHub issue #50295 has no components, please add labels for components.

Add tests for columns without non-null values

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

github-actions · 2026-06-30T16:08:48Z

⚠️ GitHub issue #50295 has no components, please add labels for components.

pitrou · 2026-06-30T16:11:05Z

@thisisnic Do you think we can upgrade the CRAN and wasm builds at some point?

(also, which wasm build is it?)

thisisnic · 2026-06-30T16:24:23Z

@thisisnic Do you think we can upgrade the CRAN and wasm builds at some point?

It's not a CI issue, the CI is up to date but it's CRAN who are using Apple Clang which apparently doesn't have ranges in its libc++

(also, which wasm build is it?)

The two failing nightlies:

test-r-macos-as-cran nightly run: https://github.com/ursacomputing/crossbow/actions/runs/28413608596
test-r-wasm: https://github.com/ursacomputing/crossbow/actions/runs/28413609309

Hmm, the wasm one might be for a different reason actually, I will check more.

rok · 2026-07-01T13:59:00Z

test-r-macos-as-cran nightly run: https://github.com/ursacomputing/crossbow/actions/runs/28413608596

test-r-wasm: https://github.com/ursacomputing/crossbow/actions/runs/28413609309

Hmm, the wasm one might be for a different reason actually, I will check more.

#50317 perhaps?

taepper · 2026-07-01T20:10:00Z

Sorry for the troubles this caused (I saw it included blocking the creation of release candidates!)

thisisnic · 2026-07-01T20:56:12Z

CI failures are unrelated, so I'll merge.

…OS CRAN and wasm builds (#50297) ### Rationale for this change R build failures due CRAN toolchain ### What changes are included in this PR? Use version of functions available on CRAN toolchain ### Are these changes tested? By existing CI jobs, and additional unit tests. ### Are there any user-facing changes? No * GitHub Issue: #50295 Lead-authored-by: Nic Crane <thisisnic@gmail.com> Co-authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Nic Crane <thisisnic@gmail.com>

conbench-apache-arrow · 2026-07-02T19:58:41Z

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit f10c93c.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 12 possible false positives for unstable benchmarks that are known to sometimes produce them.

Don't use ranges

21b0c22

Copilot AI review requested due to automatic review settings June 30, 2026 08:11

thisisnic requested a review from pitrou as a code owner June 30, 2026 08:11

Copilot started reviewing on behalf of thisisnic June 30, 2026 08:11 View session

github-actions Bot added Component: C++ awaiting committer review Awaiting committer review labels Jun 30, 2026

Copilot AI reviewed Jun 30, 2026

View reviewed changes

Comment thread cpp/src/arrow/compute/kernels/vector_select_k.cc Outdated

pitrou reviewed Jun 30, 2026

View reviewed changes

Fix underflow

05d44a5

github-actions Bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Jun 30, 2026

Add tests for columns without non-null values

f487731

thisisnic changed the title ~~GH-50295: [C++][R] #include <ranges> in vector_select_k.cc breaks macOS CRAN and wasm builds #~~ GH-50295: [C++][R] #include <ranges> in vector_select_k.cc breaks macOS CRAN and wasm builds Jun 30, 2026

Merge pull request #34 from pitrou/gh50295-additional-tests

5c1f84a

Add tests for columns without non-null values

Copilot AI review requested due to automatic review settings June 30, 2026 09:29

Copilot started reviewing on behalf of thisisnic June 30, 2026 09:29 View session

github-actions Bot added awaiting change review Awaiting change review awaiting changes Awaiting changes and removed awaiting changes Awaiting changes awaiting change review Awaiting change review labels Jun 30, 2026

Copilot AI reviewed Jun 30, 2026

View reviewed changes

pitrou approved these changes Jun 30, 2026

View reviewed changes

taepper mentioned this pull request Jul 1, 2026

GH-50247: [C++] Reuse abstraction for null partitions in sorting functions #50248

Open

thisisnic merged commit f10c93c into apache:main Jul 1, 2026
60 of 62 checks passed

thisisnic removed the awaiting changes Awaiting changes label Jul 1, 2026

thisisnic mentioned this pull request Jul 1, 2026

[C++][R] #include <ranges> in vector_select_k.cc breaks macOS CRAN and wasm builds #50295

Closed

		for (int64_t i = output.non_null_like_range.size() - 1; i >= 0; --i) {
		output.non_null_like_range[i] =

Uh oh!

Conversation

thisisnic commented Jun 30, 2026 • edited by pitrou Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Uh oh!

github-actions Bot commented Jun 30, 2026

Uh oh!

github-actions Bot commented Jun 30, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

pitrou commented Jun 30, 2026

Uh oh!

pitrou Jun 30, 2026

Choose a reason for hiding this comment

Uh oh!

pitrou Jun 30, 2026

Choose a reason for hiding this comment

Uh oh!

thisisnic Jun 30, 2026

Choose a reason for hiding this comment

Uh oh!

pitrou Jun 30, 2026

Choose a reason for hiding this comment

Uh oh!

thisisnic Jun 30, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jun 30, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

github-actions Bot commented Jun 30, 2026

Uh oh!

pitrou commented Jun 30, 2026

Uh oh!

thisisnic commented Jun 30, 2026

Uh oh!

rok commented Jul 1, 2026

Uh oh!

taepper commented Jul 1, 2026

Uh oh!

thisisnic commented Jul 1, 2026

Uh oh!

Uh oh!

conbench-apache-arrow Bot commented Jul 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

thisisnic commented Jun 30, 2026 •

edited by pitrou

Loading