WIP: Dummy PR to check maint-25.0.0 status#50329
Open
raulcd wants to merge 5 commits into
Open
Conversation
…OS CRAN and wasm builds (#50297) ### Rationale for this change R build failures due CRAN toolchain ### What changes are included in this PR? Use version of functions available on CRAN toolchain ### Are these changes tested? By existing CI jobs, and additional unit tests. ### Are there any user-facing changes? No * GitHub Issue: #50295 Lead-authored-by: Nic Crane <thisisnic@gmail.com> Co-authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Nic Crane <thisisnic@gmail.com>
This comment was marked as off-topic.
This comment was marked as off-topic.
raulcd
added
CI: Extra: C++
Member
Author
|
@github-actions crossbow submit --group packaging |
This comment was marked as outdated.
This comment was marked as outdated.
…#50328) ### Rationale for this change We need `libpng-dev` for the png R package. ### What changes are included in this PR? Install `libpng-dev`. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: #50318 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
…erGetRunDecode (#50332) ### Rationale for this change Fix compiler error. ### What changes are included in this PR? Missing typename keyword. ### Are these changes tested? In CI. ### Are there any user-facing changes? No. * GitHub Issue: #50330 Authored-by: AntoinePrv <AntoinePrv@users.noreply.github.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
Member
Author
|
@github-actions crossbow submit --group packaging |
Member
Author
|
@github-actions crossbow submit -g verify-rc-source |
|
Revision: f83c8ca Submitted crossbow builds: ursacomputing/crossbow @ actions-bcc61efff8
|
|
Revision: f83c8ca Submitted crossbow builds: ursacomputing/crossbow @ actions-60d29450e4
|
…further steps and add tag to set_enabled (#50340) ### Rationale for this change Currently when check-labels is not a pull_request even the following steps are cancelled. Also we don't enable tags execution which is required for releases. ### What changes are included in this PR? Run check-labels for the specified events and enable jobs for tags. ### Are these changes tested? I've tested on my fork by pushing to main and creating tags, more details on the comment on the PR. ### Are there any user-facing changes? No * GitHub Issue: #50293 Authored-by: Raúl Cumplido <raulcumplido@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
…se scripts (#50337) ### Rationale for this change The source verification and binary verification scripts comment to the Verification PR were failing due to the last updates to archery in order to use a single dependency. ### What changes are included in this PR? Add required base and head branches to be used when looking for a PR. Use create_issue_comment on PRs instead of create_comment which tries to create a review comment which requires more arguments. ### Are these changes tested? Yes, I've tested them locally in isolation in order to add comments on the verification PR. ### Are there any user-facing changes? No * GitHub Issue: #50336 Authored-by: Raúl Cumplido <raulcumplido@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.
Comments suppressed due to low confidence (1)
ci/scripts/r_install_system_dependencies.sh:51
libpngis only added for theapt-getpath, but this script is also used in Alpine (apk) and other distro images. If thepngR package requires libpng headers, those builds will still fail on non-apt platforms.
apk)
$PACKAGE_MANAGER add curl-dev openssl-dev libuv-dev
;;
*)
$PACKAGE_MANAGER install -y libcurl-devel openssl-devel libuv-devel
Comment on lines
+305
to
+306
| @click.option('--head-branch', default=None, | ||
| help='Set head branch for the PR.') |
Comment on lines
+133
to
138
| for (int64_t i = output_range.size(); i > 0; --i) { | ||
| output_range[i - 1] = heap.front(); // heap-top has the next element | ||
| std::pop_heap(heap.begin(), heap.end(), cmp); | ||
| // Decrease heap-size by one | ||
| heap = heap.first(heap.size() - 1); | ||
| } |
Comment on lines
+424
to
428
| for (int64_t i = output.non_null_like_range.size(); i > 0; --i) { | ||
| output.non_null_like_range[i - 1] = | ||
| heap.top().index + heap.top().offset; // heap-top has the next element | ||
| heap.pop(); | ||
| } |
| --no-fetch \ | ||
| --arrow-remote "https://github.com/${ARROW_REPOSITORY}" \ | ||
| --base-branch ${maint_branch} \ | ||
| --head-branch ${rc_branch} \ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caution
Do not merge this PR.
This PR is being used to test the status of the 25.0.0 release branch on CI and should not be merged.