Skip to content

GH-50351: [C++] Fix KeyValueMetadata::DeleteMany crash with duplicate indices #50354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AdvancedUno wants to merge 3 commits into
base: main
Choose a base branch
from
+39 −0
Open

GH-50351: [C++] Fix KeyValueMetadata::DeleteMany crash with duplicate indices #50354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ea50281
Fix KeyValueMetadata::DeleteMany crash with duplicate indices
AdvancedUno Jul 3, 2026
4383018
remove unused comments
AdvancedUno Jul 3, 2026
ec7aa4e
add clearification on remove duplicate code. may remove the comment l…
AdvancedUno Jul 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions cpp/src/arrow/util/key_value_metadata.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,17 @@ Status KeyValueMetadata::Delete(int64_t index) {
Status KeyValueMetadata::DeleteMany(std::vector<int64_t> indices) {
std::sort(indices.begin(), indices.end());
const int64_t size = static_cast<int64_t>(keys_.size());
if (ARROW_PREDICT_FALSE(!indices.empty() &&
(indices.front() < 0 || indices.back() >= size))) {
const int64_t out_of_bounds = indices.front() < 0 ? indices.front() : indices.back();
return Status::IndexError("KeyValueMetadata::DeleteMany: index ", out_of_bounds,
" is out of bounds for metadata "
"of size ",
size);
}
// Remove duplicate indices, otherwise the shifting logic below would move entries
// to incorrect (potentially negative) positions
indices.erase(std::unique(indices.begin(), indices.end()), indices.end());
indices.push_back(size);

int64_t shift = 0;
Expand Down
28 changes: 28 additions & 0 deletions cpp/src/arrow/util/key_value_metadata_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,34 @@ TEST(KeyValueMetadataTest, Delete) {
ASSERT_OK(metadata.DeleteMany({}));
ASSERT_TRUE(metadata.Equals(KeyValueMetadata({"bb", "dd", "ee"}, {"2", "4", "5"})));
}
{
KeyValueMetadata metadata(keys, values);
ASSERT_OK(metadata.DeleteMany({0, 0}));
ASSERT_TRUE(metadata.Equals(KeyValueMetadata({"bb", "cc", "dd", "ee", "ff", "gg"},
{"2", "3", "4", "5", "6", "7"})));

ASSERT_OK(metadata.DeleteMany({1, 3, 1, 3, 1}));
ASSERT_TRUE(metadata.Equals(
KeyValueMetadata({"bb", "dd", "ff", "gg"}, {"2", "4", "6", "7"})));
}
{
KeyValueMetadata metadata(keys, values);
std::string expected_error_message =
"Index error: KeyValueMetadata::DeleteMany: index 7 is out of bounds for "
"metadata "
"of size 7";
ASSERT_RAISES_WITH_MESSAGE(IndexError, expected_error_message,
metadata.DeleteMany({7}));
expected_error_message =
"Index error: KeyValueMetadata::DeleteMany: index -1 is out of bounds for "
"metadata "
"of size 7";
ASSERT_RAISES_WITH_MESSAGE(IndexError, expected_error_message,
metadata.DeleteMany({-1}));
ASSERT_RAISES(IndexError, metadata.DeleteMany({0, 3, 7}));
ASSERT_RAISES(IndexError, metadata.DeleteMany({-1, 0, 3}));
ASSERT_TRUE(metadata.Equals(KeyValueMetadata(keys, values)));
}
}

} // namespace arrow