GH-50360: [Release] Remove stray Apache-Arrow-Flight-SQL-ODBC-*-win64.msi from 04-binary-download.sh and 05-binary-upload.sh#50362
Open
raulcd wants to merge 1 commit into
Open
GH-50360: [Release] Remove stray Apache-Arrow-Flight-SQL-ODBC-*-win64.msi from 04-binary-download.sh and 05-binary-upload.sh#50362raulcd wants to merge 1 commit into
raulcd wants to merge 1 commit into
Conversation
…-win64.msi from 04-binary-download.sh and 05-binary-upload.sh
|
|
Member
Author
|
@alinaliBQ @amoeba does this look correct? |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the release automation scripts to stop downloading/uploading the Flight SQL ODBC Windows MSI in steps 04 and 05, aligning with the newer flow where the MSI is produced later (after signing) by dev/release/07-flightsqlodbc-upload.sh.
Changes:
- Remove the ODBC MSI download pattern from
04-binary-download.sh. - Remove the
UPLOAD_ODBCtoggle and the ODBC MSI upload block from05-binary-upload.sh.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| dev/release/04-binary-download.sh | Stops attempting to download Apache-Arrow-Flight-SQL-ODBC-*-win64.msi in step 04. |
| dev/release/05-binary-upload.sh | Stops attempting to GPG-sign/checksum and upload the ODBC MSI in step 05 (removes UPLOAD_ODBC). |
alinaliBQ
approved these changes
Jul 3, 2026
alinaliBQ
left a comment
alinaliBQ
left a comment
Collaborator
There was a problem hiding this comment.
ty for putting up this PR. I have one minor comment
| --pattern "ubuntu-*.tar.gz" \ | ||
| --pattern "Apache-Arrow-Flight-SQL-ODBC-*-win64.msi" \ | ||
| --repo "${REPOSITORY:-apache/arrow}" \ | ||
| --skip-existing |
Collaborator
There was a problem hiding this comment.
nit - comment # Download Linux packages and ODBC MSI. can be updated as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
When executing
05-binary-upload.shthe process failed because theApache-Arrow-Flight-SQL-ODBC-*-win64.msiisn't present.The process changed and now
dev/release/07-flightsqlodbc-upload.shwill download the following unsigned file:arrow_flight_sql_odbc_unsigned.dll from the GitHub release, sign and generated the
Apache-Arrow-Flight-SQL-ODBC-*-win64.msifile.What changes are included in this PR?
Remove trying to download and sign from steps 04 and 05 the ODBC driver msi.
Are these changes tested?
No
Are there any user-facing changes?
No