Upgrade gcsio to 3.1.16#38419
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request upgrades the gcsio library to version 3.1.16 to address issue #31896. The changes simplify the initialization of Google Cloud Storage clients by removing legacy reflection-based workarounds that were previously necessary for compatibility, and update existing test suites to align with the new library's API signatures. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request upgrades the google-cloud-bigdataoss dependency to version 3.1.16, which allows for the removal of reflection-based instantiation of GoogleCloudStorageImpl in favor of its new builder API. The changes also include updates to artifact IDs in the Gradle configuration and adjustments to method calls in GcsUtilTest.java to maintain compatibility. Review feedback suggests providing a descriptive error message when wrapping IOException in GcsUtilV1 and correcting the use of Mockito.mock() as a matcher in test stubbing to ensure proper test execution.
| googleCloudStorage = | ||
| createGoogleCloudStorage(googleCloudStorageOptions, storageClient, credentials); | ||
| } catch (IOException e) { | ||
| throw new RuntimeException(e); |
There was a problem hiding this comment.
Wrapping an IOException in a generic RuntimeException without a descriptive message makes debugging harder. It is recommended to provide context about the failure, similar to the error message used in the previous reflection-based implementation.
| throw new RuntimeException(e); | |
| throw new RuntimeException("Failed to create GoogleCloudStorage", e); |
| Mockito.when( | ||
| googleCloudStorageMock.open( | ||
| Mockito.mock(StorageResourceId.class), | ||
| Mockito.mock(GoogleCloudStorageReadOptions.class))) |
There was a problem hiding this comment.
Using Mockito.mock() as an argument in a when() call is likely a mistake. This creates a new mock instance that will not match the objects passed during the actual execution of the test, causing the stub to return null (the default for Mockito) instead of the intended mock channel. You should use Mockito.any() or specific matchers instead.
| Mockito.when( | |
| googleCloudStorageMock.open( | |
| Mockito.mock(StorageResourceId.class), | |
| Mockito.mock(GoogleCloudStorageReadOptions.class))) | |
| Mockito.when( | |
| googleCloudStorageMock.open( | |
| Mockito.any(StorageResourceId.class), | |
| Mockito.any(GoogleCloudStorageReadOptions.class))) |
|
Assigning reviewers: R: @ahmedabu98 for label java. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
1 participant
Fix #31896
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.