fix post commit yaml test#39142
Conversation
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Iceberg integration tests to use a REST catalog instead of a Hadoop catalog. It introduces a new temp_iceberg_table_with_pk fixture in integration_tests.py that spins up an Iceberg REST catalog container using testcontainers and creates a temporary table. The review feedback focuses on improving the robustness of the HTTP requests within this fixture by adding timeouts to prevent potential hangs in CI/CD environments and ensuring proper error handling when creating the database namespace.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses stability issues in the Apache Beam YAML Iceberg integration tests by replacing local filesystem-based catalog configurations with a containerized Iceberg REST catalog. This approach ensures a more robust and isolated environment for testing Iceberg read/write operations, resolving intermittent failures observed in CI pipelines. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the Iceberg integration tests to use a REST catalog container instead of a local Hadoop catalog. It introduces a new temp_iceberg_table_with_pk context manager that spins up an Iceberg REST catalog container, sets up a namespace, and creates a table with a primary key. Feedback on these changes suggests checking the namespace creation response status, passing arguments as a list to exec_run to prevent shell parsing issues, and running chmod inside the container within the finally block to ensure root-owned files created during pipeline execution can be successfully cleaned up on the host.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
Assigning reviewers: R: @claudevdm for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
* try to fix iceberg post commit test * trigger file * isort * oops more lint * lint * fix tmp dir * add timeouts per gemini comments
[Cherry pick] - fix post commit yaml test (#39142)
2 participants
Try to fix - https://github.com/apache/beam/actions/runs/28321504115
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.