[FIX] Fix IllegalThreadStateException in ComponentStarter shutdown hook#4733
Merged
[FIX] Fix IllegalThreadStateException in ComponentStarter shutdown hook#4733
Conversation
The UncaughtExceptionHandler in ComponentStarter calls shutdownHookThread.start(), but this can throw IllegalThreadStateException if the thread was already started by a prior exception or by the JVM shutdown sequence. This exception propagates out of the handler, causing the JVM to print "Exception thrown from the UncaughtExceptionHandler" on the BookieDeathWatcher thread. Catch IllegalThreadStateException since it simply means shutdown is already in progress.
hangc0276
approved these changes
Mar 24, 2026
merlimat
added a commit
that referenced
this pull request
Mar 27, 2026
…ok (#4733) The UncaughtExceptionHandler in ComponentStarter calls shutdownHookThread.start(), but this can throw IllegalThreadStateException if the thread was already started by a prior exception or by the JVM shutdown sequence. This exception propagates out of the handler, causing the JVM to print "Exception thrown from the UncaughtExceptionHandler" on the BookieDeathWatcher thread. Catch IllegalThreadStateException since it simply means shutdown is already in progress.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UncaughtExceptionHandlerinComponentStartercallsshutdownHookThread.start(), which throwsIllegalThreadStateExceptionif the thread was already started (by a prior exception or the JVM shutdown sequence)Exception: java.lang.IllegalThreadStateException thrown from the UncaughtExceptionHandler in thread "BookieDeathWatcher-<port>"IllegalThreadStateExceptionsince it simply means shutdown is already in progressTest plan