Fix class-based typed state actions - #863
Draft
FenjuFu wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ActionSchemaPydanticActionSchemaconvert BurrStatevalues into its input/output models and merge typed updates back into the original stateActionexecutionFunction/Reducerbehavior throughDEFAULT_SCHEMAfallbackRoot cause
Class-based actions could expose an
ActionSchema, but the application lifecycle only used it to validate intermediate result types.run()andupdate()still received BurrStateobjects, so model attribute access such asstate.initial_promptfailed even with a Pydantic schema.Impact
Class-based actions that expose
PydanticActionSchemanow receive the declared Pydantic input/output models. The typed model returned fromupdate()is merged into the original Burr state, preserving unrelated fields and the application typing system. Existing dict-based actions and schema-less internal reducers keep their current behavior.Validation
python -m pytest tests\core\test_application.py tests\core\test_action.py tests\integrations\test_class_based_pydantic.py tests\integrations\test_burr_pydantic.py -q鈥?326 passedpython -m ruff check burr\core\typing.py burr\core\application.py burr\integrations\pydantic.py tests\integrations\test_class_based_pydantic.pypython -m black --check tests\integrations\test_class_based_pydantic.pygit diff --checkCloses #400.
Contributed as a member of the iFLYTEK Astron community.