[CALCITE-4471] Support ignoring SYMMETRIC/ASYMMETRIC flag for between unparse

[wForget]

Thanks to @hannerwang for his work on #2328, which I wanted to take over since it hadn't been active for a long time. I also tagged @hannerwang as an author in the first commit. Fix CALCITE-4471 and CALCITE-5279

Spark/Hive/Starrocks do not support the "SYMMETRIC/ASYMMETRIC" between flags.

• Spark: https://github.com/apache/spark/blob/3ef0362174ce60e6495096b76468ea96a4a212bd/sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4#L1238
• Hive: https://github.com/apache/hive/blob/fb5e8703d915ec045a3c0148a765c9554b22bfe9/parser/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g#L710
• Starrocks: https://github.com/StarRocks/starrocks/blob/65e2d09862f451b9d79039b55d6dd0456fd90e25/fe/fe-grammar/src/main/antlr/com/starrocks/grammar/StarRocks.g4#L2694

Additionally, since Firebolt is not open source and I couldn't find the Firebolt SQL syntax definition file to determine if it applies to this change, I didn't change FireboltSqlDialect.

[wForget]

@julianhyde Could you please take a look?

[mihaibudiu]

There were some comments on the issue about SYMMETRIC that needs to output an OR of two BETWEEN conditions. Where does this happen?

[wForget]

Thank you for pointing that out — I missed that comment. It seems we're doing this conversion in toRel

calcite/core/src/main/java/org/apache/calcite/sql2rel/StandardConvertletTable.java

Line 1414 in 7654dd8

public RexNode convertBetween(

. Do we still need to do the same in unparse? Perhaps we could simply throw an exception here for unsupported SYMMETRIC calls. What do you think?

[mihaibudiu]

If the conversion was done in the convertlet table, you will never see this operator in your conversion, so there is nothing to do. You are handling the case when the conversion was not made.

[wForget]

If the conversion was done in the convertlet table, you will never see this operator in your conversion, so there is nothing to do. You are handling the case when the conversion was not made.

Makes sense

[github-actions]

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 90 days if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@calcite.apache.org list. Thank you for your contributions.