[CALCITE-6300] Function MAP_VALUES/MAP_KEYS gives exception when mapVauleType and mapKeyType not equals map Biggest mapKeytype or mapValueType#4853
Merged
caicancai merged 1 commit intoapache:mainfrom Apr 2, 2026
Conversation
Member
Author
|
@mihaibudiu Let's fix this problem completely. I will continue to follow up on this. |
mihaibudiu
reviewed
Mar 27, 2026
| if (operandTypes.get(i).getSqlTypeName() | ||
| != targetType.getSqlTypeName()) { | ||
| call.setOperand(i, | ||
| SqlStdOperatorTable.CAST.createCall(SqlParserPos.ZERO, |
Contributor
There was a problem hiding this comment.
The newly created cast node will not have a type in the typemap. You have to insert it there as well.
mihaibudiu
approved these changes
Apr 1, 2026
…auleType and mapKeyType not equals map Biggest mapKeytype or mapValueType
caicancai
added
the
LGTM-will-merge-soon
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/CALCITE-6300