[CALCITE-7456] Enable the TRY_CAST function to support the MSSQL dialect#4856
Open
cjj2010 wants to merge 3 commits intoapache:mainfrom
Open
[CALCITE-7456] Enable the TRY_CAST function to support the MSSQL dialect#4856cjj2010 wants to merge 3 commits intoapache:mainfrom
cjj2010 wants to merge 3 commits intoapache:mainfrom
Conversation
Member
|
CI seems unhappy. The commit message misses the prefix CALCITE-XXXX. |
Author
thanks, done |
cjj2010
changed the title
|
xuzifu666
approved these changes
Apr 1, 2026
Member
xuzifu666
left a comment
xuzifu666
left a comment
There was a problem hiding this comment.
If it has been thoroughly tested and verified in MSSQL, I think it's OK.
caicancai
reviewed
Apr 1, 2026
Member
caicancai
left a comment
caicancai
left a comment
There was a problem hiding this comment.
I feel the implementation is a bit strange; I'll take a look at the code and verify it tomorrow.
caicancai
requested changes
Apr 2, 2026
| final SqlWriter.Frame frame = writer.startFunCall("CEILING"); | ||
| call.operand(0).unparse(writer, leftPrec, rightPrec); | ||
| writer.endFunCall(frame); | ||
| } else if (call.getKind() == SqlKind.SAFE_CAST) { |
Member
There was a problem hiding this comment.
Manually assembling unparsed logic is repetitive and fragile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: https://issues.apache.org/jira/browse/CALCITE-7456