[CALCITE-7543] RelFieldTrimmer should preserve Join nodes instead of rebuilding them through RelBuilder.join#4960
Open
iwanttobepowerful wants to merge 1 commit into
Open
Conversation
|
|
||
| !ok | ||
|
|
||
| # [CALCITE-7543] RelFieldTrimmer should preserve Join nodes instead of rebuilding them through RelBuilder.join |
Contributor
Author
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
The link is nice, but a comment saying "this was validated using postgres" is forever in the code
mihaibudiu
reviewed
May 22, 2026
Contributor
mihaibudiu
left a comment
mihaibudiu
left a comment
There was a problem hiding this comment.
This looks fine, but @julianhyde left a comment on the issue, so I will wait for you to reply to that before I approve.
iwanttobepowerful
force-pushed
the
CALCITE-7543
branch
from
ac17919 to
a36cb71
Compare
julianhyde
approved these changes
May 22, 2026
…rebuilding them through RelBuilder.join
iwanttobepowerful
force-pushed
the
CALCITE-7543
branch
from
a36cb71 to
e27cccc
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Link
CALCITE-7543
Changes Proposed