[CALCITE-7644] Window ORDER BY expression is unparsed as positional ordinal#5081
Open
snuyanzin wants to merge 1 commit into
Open
[CALCITE-7644] Window ORDER BY expression is unparsed as positional ordinal#5081snuyanzin wants to merge 1 commit into
ORDER BY expression is unparsed as positional ordinal#5081snuyanzin wants to merge 1 commit into
Conversation
|
xiedeyantu
reviewed
Jul 5, 2026
| for (RelFieldCollation collation : group.orderKeys.getFieldCollations()) { | ||
| this.addOrderItem(orderByKeys, collation); | ||
| // A window ORDER BY has no ordinal notion; resolve via field(). | ||
| this.addOrderItem(orderByKeys, collation, false); |
Member
There was a problem hiding this comment.
It seems this branch isn't covered by tests. Could you show the execution results for the case where the value is false?
Contributor
Author
There was a problem hiding this comment.
didn't get what you mean by that, can you elaborate please?
This is exactly the case covered by testWindowOrderByExpression in this PR
Member
There was a problem hiding this comment.
Oh, I see—regarding the addOrderItem method, you added a parameter called allowsOrdinal. The case statement seems to cover the scenario where allowsOrdinal is true; if I’m not mistaken, shouldn't there also be a case for when it is false?
mihaibudiu
approved these changes
Jul 6, 2026
mihaibudiu
added
the
LGTM-will-merge-soon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Link
CALCITE-7644
Changes Proposed
in case of
OVER(...)window'sORDER BYshould be passed as a field expression rather than positional ordinal (also see jira issue description)