[CALCITE-6393] Byte code of SqlFunctions is invalid#5091
Merged
Conversation
thomasrebele
approved these changes
Jul 10, 2026
thomasrebele
left a comment
thomasrebele
left a comment
Contributor
There was a problem hiding this comment.
Thank you for the PR, @rubenada! LGTM.
|
rubenada
added
the
LGTM-will-merge-soon
xiedeyantu
approved these changes
Jul 10, 2026
Contributor
Author
|
Thanks @thomasrebele , @xiedeyantu for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Link
CALCITE-6393
Changes Proposed
Use a static method (instead of a lambda) for
ARRAY_CARTESIAN_PRODUCT. This avoids a JDK 8 and 11 bug that produces invalid bytecode regarding checkerframework annotations.Verified using bytecode checker proposed in #5090
More info: Body of the
ARRAY_CARTESIAN_PRODUCTlambda extracted into an ordinary static method so that its@Nullabletype annotations on doubly-nested type arguments (e.g.List<Enumerator<@Nullable Object>>) are attached the method's attribute table rather than to the enclosing<clinit>. This works around a javac bug in which type annotations declared inside a lambda body are emitted into the enclosing<clinit>attribute table with the lambda's own bytecode PCs and local-variable slots, producing malformedRuntimeVisibleTypeAnnotationsentries that ASM'sClassRemapperrejects.