[CALCITE-7649] Add bytecode verification check using ASM in the gradle build#5092
Draft
thomasrebele wants to merge 2 commits into
Draft
[CALCITE-7649] Add bytecode verification check using ASM in the gradle build#5092thomasrebele wants to merge 2 commits into
thomasrebele wants to merge 2 commits into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This is a rebase of @zabetak's PR #3783. I've fixed some warnings by adapting AsmCheckerTask to Gradle 8. I had to exclude
spark/build/sparkServer/classes, as the classes in that dir failed the check.I've verified the functionality by building a183b26 (i.e., without the fix for the invalid bytecode of CALCITE-6393) with JDK8. As expected, it produces
java.lang.RuntimeException: Invalid bytecode file:/home/trebele/dev/calcite/c1/core/build/classes/java/main/org/apache/calcite/runtime/SqlFunctions.classwhen running./gradlew build. The build passes with JDK17 and JDK21.Here the versions that I've used:
Jira Link
CALCITE-7649
Changes Proposed
This PR proposes to add a check to fail the build if it produced invalid bytecode.