[CALCITE-7655] RelToSqlConverter incorrectly removes a subquery when grouping by a window function result#5101
Open
zzwqqq wants to merge 2 commits into
Open
[CALCITE-7655] RelToSqlConverter incorrectly removes a subquery when grouping by a window function result#5101zzwqqq wants to merge 2 commits into
zzwqqq wants to merge 2 commits into
Conversation
…by a window function result
zzwqqq
changed the title
|
xuzifu666
reviewed
Jul 14, 2026
| * <a href="https://issues.apache.org/jira/browse/CALCITE-7655">[CALCITE-7655] | ||
| * RelToSqlConverter incorrectly removes a subquery when grouping by a window function | ||
| * result</a>. */ | ||
| @Test void testGroupByWindowFunction() { |
Member
There was a problem hiding this comment.
As you described in Jira, the default generated SQL is not supported by many databases; therefore, the tests here should include the appropriate dialect to verify that the generated SQL is valid for the databases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Link
CALCITE-7655
Changes Proposed
RelToSqlConvertercould incorrectly remove a required subquery when an outer aggregate groups by the result of an inner window function. This caused the window function to appear directly in the generatedGROUP BYclause:Window functions are not allowed in
GROUP BY. I verified that this SQL fails on MySQL, PostgreSQL, and Oracle.The fix detects window expressions referenced by aggregate group keys and preserves the input subquery.