CAMEL-23535: camel-api - batches 16-20: enhance class-level Javadoc for REST, tooling, properties, exchange, and root-package types#24098
Conversation
…ST SPIs Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…I and model-dumper SPIs Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…operties, language, and resolver SPIs Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…change processing SPIs Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ot-package exception and utility types Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
davsclaus
left a comment
There was a problem hiding this comment.
Clean documentation-only PR — enhanced class-level Javadoc across 26 files in core/camel-api with clear architecture context, {@link} references, manual links, and @see tags. No behavioral changes.
Two minor non-blocking observations:
-
UnitOfWorkFactorysemantic shift: The old Javadoc says extendingDefaultUnitOfWorkis "highly recommended"; the new text strengthens this to "must extend" and explains the consequences. More informative, but changes the documented contract strength. -
HeadersMapFactorydropped@see: The old@see org.apache.camel.impl.engine.DefaultHeadersMapFactory(pointing to the default impl) was replaced with@see Message. Both valid — the old one was useful for implementors.
This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.
|
🧪 CI tested the following changed modules:
|
|
Thank you for the review! Both observations addressed in cdb71dc:
Claude Code on behalf of Adriano Machado |
Description
Continues CAMEL-23535.
This PR covers batches 16-20: 26 files in
core/camel-apireceived enhanced class-level Javadoc. The changes are documentation-only; no method signatures, annotations, or production code were altered.Batch 16 — REST SPIs (
spi/)RestConfiguration,RestProducerFactory,RestRegistry,RestBindingJaxbDataFormatFactory,RestApiConsumerFactoryBatch 17 — CLI and model-dumper SPIs (
spi/)CliConnector,CliConnectorFactory,ModelToXMLDumper,ModelToYAMLDumper,ModelToJavaDumper,RouteTopologyDumperBatch 18 — Properties, language, and resolver SPIs (
spi/)PropertiesComponent,PropertiesFunction,Language,LanguageResolver,DataFormatResolver,RoutesBuilderLoader,HeadersMapFactoryBatch 19 — Exchange processing SPIs (
spi/)LifecycleStrategy,UnitOfWork,UnitOfWorkFactory,InflightRepositoryBatch 20 — Root-package utility and exception types (
org.apache.camel)NoSuchBeanException,StaticService,SSLContextParametersAware,NoFactoryAvailableExceptionEach file received:
{@link}references and explanation of callers/lifecycle<a href>link where a matching page exists@seetags for closely related sibling types@sincetagsTarget
mainbranch)Tracking
Apache Camel coding standards and style
mvn clean install -DskipTestslocally from root folder and I have committed all auto-generated changes.Claude Code on behalf of Adriano Machado