CASSANALYTICS-172 : Integration tests for missing test scenarios#215
Open
skoppu22 wants to merge 1 commit into
Open
CASSANALYTICS-172 : Integration tests for missing test scenarios#215skoppu22 wants to merge 1 commit into
skoppu22 wants to merge 1 commit into
Conversation
jmckenzie-dev
requested changes
Jul 9, 2026
jmckenzie-dev
left a comment
jmckenzie-dev
left a comment
Contributor
There was a problem hiding this comment.
One very low priority nit and one thing I'm not really sure of. Looks great otherwise. :)
| table, partitionKey, clusteringKey, staticValue, regularValue)); | ||
| } | ||
| } | ||
| flushKeyspace(table); |
Contributor
There was a problem hiding this comment.
I think you need to flush after every static value write so you get SSTables w/competing values that will then exercise the LWW semantics here don't you?
| * Verifies partition-key pushdown on the bulk reader, both single-value ({@code a = N}) and | ||
| * multi-value ({@code a IN (...)}) forms. | ||
| * | ||
| * <p>The OSS bulk reader's {@code CassandraDataSource} accepts partition-key predicates as |
Contributor
There was a problem hiding this comment.
Super ultra-nit: why do we refer to this as "The OSS bulk reader" here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding in-jvm tests for some of missing test scenarios
Circle CI : https://app.circleci.com/pipelines/github/skoppu22/cassandra-analytics/133/workflows/603c52b1-7900-4be5-9d83-091f1cc3cb28