Fix operationMode stuck in DECOMMISSION_FAILED during resumed decommission#4920
Open
minal-kyada wants to merge 1 commit into
Open
Fix operationMode stuck in DECOMMISSION_FAILED during resumed decommission#4920minal-kyada wants to merge 1 commit into
minal-kyada wants to merge 1 commit into
Conversation
minal-kyada
force-pushed
the
node-decommission-fix
branch
from
6f449e5 to
a05b7f2
Compare
minal-kyada
force-pushed
the
node-decommission-fix
branch
from
a05b7f2 to
c081555
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: When a node's decommission fails mid stream, it enters DECOMMISSION_FAILED mode. On the subsequent
decommission --forceresume,clearTransientMode()was never called, sooperationMode()remained stuck asDECOMMISSION_FAILEDthroughout the resumed streaming, even though the node was actively leaving.Fix: Added a
clearTransientMode()call on the resume branch ofdecommission(), mirroring the same pattern already used by every other path that recovers a node from a failed state.patch by @minal-kyada ; reviewed by @maedhroz and @beobal for CASSANDRA-21493